[webkit-reviews] review granted: [Bug 118832] WorkerGlobalScope should support onoffline/ononline event handlers : [Attachment 207034] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 118832: WorkerGlobalScope should support onoffline/ononline event handlers
https://bugs.webkit.org/show_bug.cgi?id=118832

Attachment 207034: Patch
https://bugs.webkit.org/attachment.cgi?id=207034&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207034&action=review


Looks good to me. Please consider the suggestion below.

> Source/WebCore/platform/network/NetworkStateNotifier.h:84
> +    HashSet<NetworkStateChangeListener> m_listeners;

Given that there is no way to remove from the set, and that the only operation
we need is iteration, it seems much more efficient to use a vector than a
HashSet.