[webkit-reviews] review granted: [Bug 118536] Non-Cairo platforms should be able to use EGL : [Attachment 207019] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 118536: Non-Cairo platforms should be able to use EGL
https://bugs.webkit.org/show_bug.cgi?id=118536

Attachment 207019: Patch
https://bugs.webkit.org/attachment.cgi?id=207019&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=207019&action=review


r=me

> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:28
> +#include <cairo.h>

I guess the 2D drawing stuff is not brought in with the 3D graphics context. 
We may end up with a big ifdef block here.

> Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:229
> +#endif

Ditto -- other platforms will probably have similar cleanup requirements.