[webkit-reviews] review denied: [Bug 118832] WorkerGlobalScope should support onoffline/ononline event handlers : [Attachment 206962] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 118832: WorkerGlobalScope should support onoffline/ononline event handlers
https://bugs.webkit.org/show_bug.cgi?id=118832

Attachment 206962: Patch
https://bugs.webkit.org/attachment.cgi?id=206962&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206962&action=review


> Source/WebCore/workers/WorkerGlobalScope.cpp:118
> +static Mutex& workerGlobalScopeSetMutex()
> +{
> +    AtomicallyInitializedStatic(Mutex&, mutex = *new Mutex);
> +    return mutex;
> +}

This is not cool, adding mutexes complicates the design and makes deadlocks
more likely.

Talking to workers should be done through WorkerGlobalScopeProxy, there is no
need to create new cross-thread messaging mechanisms for that.