[webkit-reviews] review denied: [Bug 118797] [EFL][WK2] Replace mouseClick with more meaningful method in test_ewk2_color_picker.cpp : [Attachment 206939] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 118797: [EFL][WK2] Replace mouseClick with more meaningful method in
test_ewk2_color_picker.cpp
https://bugs.webkit.org/show_bug.cgi?id=118797

Attachment 206939: Patch
https://bugs.webkit.org/attachment.cgi?id=206939&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206939&action=review


> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:114
> +    void clickColorPicker(Visible visible)

This does not really click the color picker. It clicks a button. How about:
enum Button { ShowColorPickerButton, HideColorPickerButton };
clickButton(Button button);