[webkit-reviews] review denied: [Bug 118548] [EFL][WK2] Correct wrong usage of m_contentPosition variable in the WebView. : [Attachment 206426] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 118548: [EFL][WK2] Correct wrong usage of m_contentPosition variable in the
WebView.
https://bugs.webkit.org/show_bug.cgi?id=118548

Attachment 206426: Patch
https://bugs.webkit.org/attachment.cgi?id=206426&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206426&action=review


> Source/WebKit2/ChangeLog:10
> +	   The m_contentPosition variable is scaled position which is scaled
with
> +	   content scale factor. It can be confused with real position which is

> +	   known in the webcore, so it should be used carefully.

I don't get what this says, or what this patch does differently.

> Source/WebKit2/UIProcess/CoordinatedGraphics/WebView.cpp:248
> +	   FloatPoint position = contentPosition();
> +	   position.scale(1 / m_contentScaleFactor, 1 / m_contentScaleFactor);
> +	   FloatRect visibleContentsRect(position, visibleContentsSize());

This does not explain itself, nor it is explained in the Changelog.