[webkit-reviews] review denied: [Bug 118686] Dereference null pointer crash in Length::decrementCalculatedRef() : [Attachment 206908] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 17 12:59:49 PDT 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Jacky Jiang
<jkjiang at webkit.org>'s request for review:
Bug 118686: Dereference null pointer crash in Length::decrementCalculatedRef()
https://bugs.webkit.org/show_bug.cgi?id=118686

Attachment 206908: Patch
https://bugs.webkit.org/attachment.cgi?id=206908&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206908&action=review


> Source/WebCore/ChangeLog:17
> +	   Test: css3/calc/transition-transform-translate-crash.html

This test name should have "calc" in it somewhere.

> LayoutTests/css3/calc/transition-transform-translate-crash.html:6
> +    div#div2 {

You don't need to specify the tag name if you are also using an id.

You could do divs at the same time with a class on the body or a container div.


> LayoutTests/css3/calc/transition-transform-translate-crash.html:19
> +	   testRunner.waitUntilDone();

You don't need waitUntilDone()/notifyDone() unless the test also uses
setTimeout().


More information about the webkit-reviews mailing list