[webkit-reviews] review denied: [Bug 117383] [GStreamer] Add handling for GstContext : [Attachment 206898] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Víctor M. Jáquez L.
<vjaquez at igalia.com>'s request for review:
Bug 117383: [GStreamer] Add handling for GstContext
https://bugs.webkit.org/show_bug.cgi?id=117383

Attachment 206898: Patch
https://bugs.webkit.org/attachment.cgi?id=206898&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206898&action=review


Seems reasonable, but I think a smart pointer is the way to go here.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:156
> +    GstStructure* s2 = reinterpret_cast<GstStructure*>(userData);

Please don't use obscure abbreviations for variable names.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:269
> +	   gst_context_unref(m_context);

Looks like this could be a RefPtr specialization which would allow you to avoid
the initialization and destruction of this member.

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:858
> +	       s1 = gst_context_get_structure(newContext);
> +	       s2 = gst_context_writable_structure(m_context);

Please make these variable names real words and declare them when you first
define them.