[webkit-reviews] review denied: [Bug 118759] [EFL] ewk_settings_application_cache_path_set should be called once in test_ewk_setting.cpp : [Attachment 206834] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 118759: [EFL] ewk_settings_application_cache_path_set should be called once
in test_ewk_setting.cpp
https://bugs.webkit.org/show_bug.cgi?id=118759

Attachment 206834: Patch
https://bugs.webkit.org/attachment.cgi?id=206834&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206834&action=review


> Source/WebKit/efl/tests/test_ewk_setting.cpp:-127
> -    ewk_settings_application_cache_path_set("~/tmp/webkitApp");

Instead of removing the check, it would be better to keep it to make sure that:

- it does not crash (especially in debug)
- the path is not changed the second time

This may require some fixes in WebKit but I'm sure you can manage :)