[webkit-reviews] review granted: [Bug 118739] REGRESSION (r150291): Chinese predictive input pop-up disappears on twitter.com : [Attachment 206808] proposed fix

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 118739: REGRESSION (r150291): Chinese predictive input pop-up disappears on
twitter.com
https://bugs.webkit.org/show_bug.cgi?id=118739

Attachment 206808: proposed fix
https://bugs.webkit.org/attachment.cgi?id=206808&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206808&action=review


r=me

> Source/WebKit2/UIProcess/mac/WebPageProxyMac.mm:224
> +    m_temporarilyClosedComposition = false;

I'm unclear if you're unhappy about this addition given your ChangeLog remark
on it being a "targeted fix just for this specific [bug]". If you're unhappy
about this change then I suggest we add a FIXME comment and/or file a bug (and
reference it in the FIXME comment) so that we may revisit this fix should we
come up with a better approach at a later date.

On another note, I noticed that WebPageProxy::m_temporarilyClosedComposition is
only used in the Apple Mac WebKit port (as of the time of writing). We should
consider guarding it with an #idef so as to make it clear at the call site that
it's specific to the Apple Mac WebKit port. Obviously we should look to better
encapsulate such Mac-specific implementation details so as to minimize the use
of platform-specific #ifdefs in platform-independent files.