[webkit-reviews] review denied: [Bug 18305] Border drawing incorrect when using both border-collapse: collapse and overflow: hidden on a table : [Attachment 206603] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 18305: Border drawing incorrect when using both border-collapse: collapse
and overflow: hidden on a table
https://bugs.webkit.org/show_bug.cgi?id=18305

Attachment 206603: Patch
https://bugs.webkit.org/attachment.cgi?id=206603&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206603&action=review


r-

> Source/WebCore/rendering/RenderTableCell.cpp:1004
> +LayoutRect RenderTableCell::overflowClipRect(const LayoutPoint& location,
RenderRegion* region, OverlayScrollbarSizeRelevancy relevancy)

I don't understand any of these table cell changes really.  In the
self-painting layers case, the cell gets clipped properly already by
overflowClipRectForChildLayers. In the case where the table cell has no layer,
why not just simulate the same thing and re-use overflowClipRectForChildLayers.
Make the table code actually push the overflowClipRectForChildLayers clip
before painting kids.

I really think done right you don't have to touch RenderTableCell at all.