[webkit-reviews] review granted: [Bug 118736] Fix some NSDictionary misuse pointed out by the clang static analyzer : [Attachment 206791] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 16 10:20:26 PDT 2013


Anders Carlsson <andersca at apple.com> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 118736: Fix some NSDictionary misuse pointed out by the clang static
analyzer
https://bugs.webkit.org/show_bug.cgi?id=118736

Attachment 206791: Patch
https://bugs.webkit.org/attachment.cgi?id=206791&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206791&action=review


> Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm:380
>      NSDictionary *dictionary = [[NSDictionary alloc] initWithObjectsAndKeys:
excludedElements, NSExcludedElementsDocumentAttribute, 

Seems like this can just use dictionaryWithObject:forKey:

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:114
> -	   NSExcludedElementsDocumentAttribute, nil, @"WebResourceHandler",
nil];
> +	   NSExcludedElementsDocumentAttribute, nil];

Ditto.


More information about the webkit-reviews mailing list