[webkit-reviews] review denied: [Bug 118733] Javascript JIT still allocates 2GB of memory on x86-64 Linux : [Attachment 206778] Use MAP_32BIT

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied  review:
Bug 118733: Javascript JIT still allocates 2GB of memory on x86-64 Linux
https://bugs.webkit.org/show_bug.cgi?id=118733

Attachment 206778: Use MAP_32BIT
https://bugs.webkit.org/attachment.cgi?id=206778&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206778&action=review


>
b/src/3rdparty/javascriptcore/JavaScriptCore/jit/ExecutableAllocatorFixedVMPool
.cpp:44
> -#ifdef QT_USE_ONEGB_VMALLOCATOR
> -    #define VM_POOL_SIZE (1024u * 1024u * 1024u) // 1Gb
> -#else
> -    #define VM_POOL_SIZE (2u * 1024u * 1024u * 1024u) // 2Gb
> -#endif
> +    // On x86-64, where we require all jumps to have a 2Gb max range we'll
use
> +    // MAP_32BIT
> +    #define VM_POOL_SIZE (32u * 1024u * 1024u) // 32Mb

Nope, we aren't taking a 32Mb JIT segment on 64 bit, also this leads to an
incorrect comment.

The comment also becomes wrong