[webkit-reviews] review denied: [Bug 118725] [Qt] syncqt doesn't generate the forwarding headers in SVN repositories. : [Attachment 206764] proposed patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied	review:
Bug 118725: [Qt] syncqt doesn't generate the forwarding headers in SVN
repositories.
https://bugs.webkit.org/show_bug.cgi?id=118725

Attachment 206764: proposed patch
https://bugs.webkit.org/attachment.cgi?id=206764&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206764&action=review


>> .qmake.conf:6
>> +CONFIG+=git_build
> 
> It would be great to have a more descriptive comment here, for example same
as in the changelog:
> # Workaround to make syncqt run and generate forwarding headers in SVN
repositories too
> # https://bugs.webkit.org/show_bug.cgi?id=118725

I agree with Ossy about the comment. This should also be guarded by a check for
an actual .svn directory.