[webkit-reviews] review denied: [Bug 110136] [WK2][Soup] Add entry point for network process : [Attachment 205987] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 110136: [WK2][Soup] Add entry point for network process
https://bugs.webkit.org/show_bug.cgi?id=110136

Attachment 205987: Patch
https://bugs.webkit.org/attachment.cgi?id=205987&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205987&action=review


> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:51
> +    // FIXME: Event loop is not initialized correctly for EFL. For EFL we
should should either
> +    // initialize ecore or use the glib-only RunLoop implementation in the
network process.

Why is it not initialized correctly? I guess you need to call
ecore_main_loop_glib_integrate() before calling InitializeWebKit2?

> Source/WebKit2/NetworkProcess/unix/NetworkProcessMainUnix.cpp:63
> +    errno = 0;
> +    long int socket = strtol(argv[1], 0, 10);
> +    if (errno)
> +	   return 1;
> +
> +    WebKit::ChildProcessInitializationParameters parameters;
> +    parameters.connectionIdentifier = int(socket);

On other entry points we use atoi() to go straight to int and avoid this error
checking and conversion dance. I would prefer if we kept this consistent.

> Source/WebKit2/unix/NetworkMainUnix.cpp:2
> + * Copyright (C) 2013 University of Szeged. All rights reserved.

This is trivial enough that I don't think you need to import the copyright.