[webkit-reviews] review granted: [Bug 118717] [EFL][WK2] EWK2BackForwardListTest should be defined by inheriting from EWK2UnitTestBase : [Attachment 206735] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has granted Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 118717: [EFL][WK2] EWK2BackForwardListTest should be defined by inheriting
from EWK2UnitTestBase
https://bugs.webkit.org/show_bug.cgi?id=118717

Attachment 206735: Patch
https://bugs.webkit.org/attachment.cgi?id=206735&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206735&action=review


r=me with nits.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:63
> +    inline void checkItem(Ewk_Back_Forward_List_Item* item, const char*
title, const char* url, const char* originalURL)

Please remove the "inline" here and below. They likely don't bring anything
here since the methods are implemented in the body of the class declaration.