[webkit-reviews] review granted: [Bug 118347] Update blocked/missing plug-in UI : [Attachment 206704] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 118347: Update blocked/missing plug-in UI
https://bugs.webkit.org/show_bug.cgi?id=118347

Attachment 206704: patch
https://bugs.webkit.org/attachment.cgi?id=206704&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206704&action=review


> Source/WebCore/ChangeLog:8
> +	   Patch by Anders Carlsson, Antoine Quint, Sam Weinig, and myself.

Did I contribute to this? I remember this not.

> Source/WebCore/rendering/RenderEmbeddedObject.cpp:299
> +    LayoutRect rect;
> +    if (m_indicator && m_indicator->renderer())
> +	   rect = m_indicator->renderer()->absoluteBoundingBoxRect();
> +    else
> +	   rect = LayoutRect();
> +

Is the else statement necessary?