[webkit-reviews] review granted: [Bug 117435] Add support for WaveShaperNode.oversample : [Attachment 206681] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 117435: Add support for WaveShaperNode.oversample
https://bugs.webkit.org/show_bug.cgi?id=117435

Attachment 206681: Patch
https://bugs.webkit.org/attachment.cgi?id=206681&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206681&action=review


r=me based on previous review and comparing to the earlier CL.

> Source/WebCore/platform/audio/DownSampler.cpp:44
> +    , m_inputBuffer(inputBlockSize * 2)

I noticed the initialization order differs from Blink's (and Blink's is likely
wrong, not having the same warnings enabled as errors as WebKit). Do you plan
to fix Blink's code?

> Source/WebCore/platform/audio/UpSampler.cpp:44
> +    , m_inputBuffer(inputBlockSize * 2)

Same comment about initialization order.