[webkit-reviews] review denied: [Bug 118239] [GTK] Make DRT obbey testRunner's addURLToRedirect : [Attachment 205805] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Simon Pena
<simon.pena at samsung.com>'s request for review:
Bug 118239: [GTK] Make DRT obbey testRunner's addURLToRedirect
https://bugs.webkit.org/show_bug.cgi?id=118239

Attachment 205805: Patch
https://bugs.webkit.org/attachment.cgi?id=205805&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205805&action=review


r- because of the leak

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1305
> +    if (destination.length())

Checking for length() here feels wrong to me, there is empty(), but it looks
like the Mac port does the same so *shrug*.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1306
> +	   webkit_network_request_set_uri(request,
strdup(destination.c_str()));

Should not need to strdup the string here. Did you have trouble with the
c_str() being destroyed early or something? In any case, you are leaking the
result here since set_uri does not take ownership of the passed string.