[webkit-reviews] review denied: [Bug 118598] [WK2][Soup] Use didReceiveBuffer instead of didReceiveData : [Attachment 206544] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 118598: [WK2][Soup] Use didReceiveBuffer instead of didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=118598

Attachment 206544: Patch
https://bugs.webkit.org/attachment.cgi?id=206544&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
As discussed in bug 118448, the other approach (using didReceiveData) seems to
be more sound for soup, since we already use a data pointer and length instead
of a buffer object. Wrapping the data in SoupBuffer just adds unnecessary churn
and complexity. I took it from what Brady said that he'd be OK with our having
didReceiveData in our own NetworkResourceLoaderSoup.cpp, right? I'm setting r-
for that reason, we can re-visit if there is actually opposition to the patch
from bug 118448.