[webkit-reviews] review denied: [Bug 118657] [WK2][Soup] Add private browsing support : [Attachment 206641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 15 08:01:37 PDT 2013


Gustavo Noronha (kov) <gns at gnome.org> has denied Kwang Yul Seo
<skyul at company100.net>'s request for review:
Bug 118657: [WK2][Soup] Add private browsing support
https://bugs.webkit.org/show_bug.cgi?id=118657

Attachment 206641: Patch
https://bugs.webkit.org/attachment.cgi?id=206641&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206641&action=review


r- because of the style issues and because I feel we should figure out the
identifier base before landing this

> Source/WebCore/platform/network/NetworkStorageSession.h:53
> +    bool isPrivateBrowsingSession() const { return m_isPrivate; }

This should be kept under a PLATFORM(MAC) || USE(CFNETWORK) || USE(SOUP) check,
since it's still not universally supported.

> Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:1408
> +    // FIXME: Handle identifierBase

What do you mean handle identifierBase? What do you need to do with it?

>
Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:32
>  

There should be no empty line here.


More information about the webkit-reviews mailing list