[webkit-reviews] review requested: [Bug 118583] [EFL] Add fallback for TestWebKitAPI if opengl is not available. : [Attachment 206506] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 14 20:37:03 PDT 2013


Donggwan Kim <donggwan.kim at samsung.com> has asked  for review:
Bug 118583: [EFL] Add fallback for TestWebKitAPI if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=118583

Attachment 206506: Patch
https://bugs.webkit.org/attachment.cgi?id=206506&action=review

------- Additional Comments from Donggwan Kim <donggwan.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206506&action=review


>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:48
>> +	Ecore_Evas* ecoreEvas = 0;
> 
> initialization does not seem needed.

Done.

>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:50
>> +	const char* engine = "opengl_x11";
> 
> This variable is not needed. please pass "opengl_x11" directly to
ecore_evas_new().

Done.

>> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-54
>> -	ASSERT(ecoreEvas);
> 
> Why remove the assertion?

You are right. I appended the assertion again.


More information about the webkit-reviews mailing list