[webkit-reviews] review denied: [Bug 118650] CoordinatedGraphics: Set scene to active in WebView::paintToCurrentGLContext() : [Attachment 206623] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 118650: CoordinatedGraphics: Set scene to active in
WebView::paintToCurrentGLContext()
https://bugs.webkit.org/show_bug.cgi?id=118650

Attachment 206623: Patch
https://bugs.webkit.org/attachment.cgi?id=206623&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206623&action=review


> Source/WebKit2/ChangeLog:12
> +	   Previously, the scene was set to active in WebView::initialize(),
but then
> +	   if the Web Process crashed and we needed to recreate the drawing
area, via
> +	   WebPageProxy::initializeWebPage(), it would create a new scene which
would
> +	   never be set to active, and from that point on, we would only get a
blank
> +	   view.

don't we get some kind of event, like didInitialize?
Setting the scene to active during paint doesn't seem like the right solution.

> Source/WebKit2/ChangeLog:19
> +	   A simple way to verify this behavior on the EFL port would be to
kill the
> +	   Web Process:
> +
> +	   $ killall WebProcess
> +
> +	   After this, you will only get a blank view.

This requires an API test.