[webkit-reviews] review canceled: [Bug 115905] Do not copy the HashMap template for use with RefPtr keys : [Attachment 204810] fixed MAC build

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 12 09:16:12 PDT 2013


Mikhail Pozdnyakov <mikhail.pozdnyakov at intel.com> has canceled Mikhail
Pozdnyakov <mikhail.pozdnyakov at intel.com>'s request for review:
Bug 115905: Do not copy the HashMap template for use with RefPtr keys
https://bugs.webkit.org/show_bug.cgi?id=115905

Attachment 204810: fixed MAC build
https://bugs.webkit.org/attachment.cgi?id=204810&action=review

------- Additional Comments from Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>
Added alternate versions of HasMap interface methods which do not enforce
converting key arguments to Key type but instead let HasMap's own
HashTranslator to deal with them. Using of these functions do not usually
require any extra effort on client side (e.g., explicit passing of used
HashTranslator). Using of these methods is benefitial if Key type has some
relative types that could be handled by HasMap's HashFunctions - objects of
these types can be used as the key arguments, for example smart pointers and
raw pointers of the same type or various string classes.

This approach is also much simpler than all the previous ones.


More information about the webkit-reviews mailing list