[webkit-reviews] review denied: [Bug 118583] [EFL] Add fallback for TestWebKitAPI if opengl is not available. : [Attachment 206506] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Donggwan Kim
<donggwan.kim at samsung.com>'s request for review:
Bug 118583: [EFL] Add fallback for TestWebKitAPI if opengl is not available.
https://bugs.webkit.org/show_bug.cgi?id=118583

Attachment 206506: Patch
https://bugs.webkit.org/attachment.cgi?id=206506&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206506&action=review


> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:48
> +    Ecore_Evas* ecoreEvas = 0;

initialization does not seem needed.

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:50
> +    const char* engine = "opengl_x11";

This variable is not needed. please pass "opengl_x11" directly to
ecore_evas_new().

> Tools/TestWebKitAPI/efl/PlatformWebView.cpp:-54
> -    ASSERT(ecoreEvas);

Why remove the assertion?