[webkit-reviews] review canceled: [Bug 114871] [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries : [Attachment 203441] Patch proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has canceled Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 114871: [GTK] Reimplement atk_text_get_text_*_offset for WORD boundaries
https://bugs.webkit.org/show_bug.cgi?id=114871

Attachment 203441: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=203441&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
After working for a while on the previous patch + the suggestions from Martin,
I realized there were some issues with that patch that needed more changes, so
here you have the new patch, which I believe works at least as well (or as bad)
as the previous -pango based- implementation. I'd even say it works better, at
least in the tests I did, but I'm prudent and won't say that :)

Additionally, I found some issues while developing it (some of them already
present in the previous implementation) that I've fixed along the way with this
patch, so that's why I'm also providing a new unit test for checking things
related to embedded objects, and extending a bit previous ones.

I'd therefore kindly ask for a review over this one and will move on to the
LINE boundary in the meantime... getting closer to the no-pango thing!