[webkit-reviews] review denied: [Bug 118585] Share Qt port's codes to find zoomable area with coordinated graphics. : [Attachment 206509] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied EunMi Lee
<eunmi15.lee at samsung.com>'s request for review:
Bug 118585: Share Qt port's codes to find zoomable area with coordinated
graphics.
https://bugs.webkit.org/show_bug.cgi?id=118585

Attachment 206509: Patch
https://bugs.webkit.org/attachment.cgi?id=206509&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206509&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:2952
> +#if PLATFORM(QT) || USE(COORDINATED_GRAPHICS)

No need for #if PLATFORM(QT) here
Qt already uses coordinated graphics.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:2953
> +void WebPageProxy::findZoomableAreaForPoint(const IntPoint& point, const
IntSize& area)

Maybe we can put this in a new file (WebPageProxyCoordinatedGraphics)?

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:3221
> +    IntRect zoomableArea = node->pixelSnappedBoundingBox();

This seems like a separate fix