[webkit-reviews] review granted: [Bug 118572] Plugins that don't support snapshotting should not all autostart. : [Attachment 206477] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Roger Fong <roger_fong at apple.com>'s
request for review:
Bug 118572: Plugins that don't support snapshotting should not all autostart.
https://bugs.webkit.org/show_bug.cgi?id=118572

Attachment 206477: Patch
https://bugs.webkit.org/attachment.cgi?id=206477&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206477&action=review


> Source/WebCore/html/HTMLPlugInImageElement.cpp:387
> +    argList.append(JSC::jsBoolean(!m_snapshotImage));

I think we should put a comment here to explain that this parameter determines
if the overlay should be always visible, which we want when we don't have a
good snapshot.