[webkit-reviews] review denied: [Bug 118573] API Shims don't need thread lock if the VM is not a APIShared type : [Attachment 206480] proposal patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 11 13:22:45 PDT 2013


Geoffrey Garen <ggaren at apple.com> has denied Yi Shen
<max.hong.shen at gmail.com>'s request for review:
Bug 118573: API Shims don't need thread lock if the VM is not a APIShared type
https://bugs.webkit.org/show_bug.cgi?id=118573

Attachment 206480: proposal patch
https://bugs.webkit.org/attachment.cgi?id=206480&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Even unshared VMs need locking, since they can be used on more than one thread.


I'm intrigued by your test case, though. Maybe there's another way to optimize
this.


More information about the webkit-reviews mailing list