[webkit-reviews] review denied: [Bug 118534] [buildfix] Fix build on gcc 4.8.1 when compiling with -Werror=maybe-uninitialized : [Attachment 206399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 11 11:39:27 PDT 2013


Geoffrey Garen <ggaren at apple.com> has denied Hugo Parente Lima
<hugo.lima at openbossa.org>'s request for review:
Bug 118534: [buildfix] Fix build on gcc 4.8.1 when compiling with
-Werror=maybe-uninitialized
https://bugs.webkit.org/show_bug.cgi?id=118534

Attachment 206399: Patch
https://bugs.webkit.org/attachment.cgi?id=206399&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I'd prefer to see "switch (static_cast<Enum>(info.mode))" here.

Adding the default case means the compiler won't warn us if we forget an enum
value in the switch statement.


More information about the webkit-reviews mailing list