[webkit-reviews] review granted: [Bug 118568] Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable : [Attachment 206474] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 11 10:26:34 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 118568: Use GOwnPtr in PluginProcessProxyUnix to manage stdOut variable
https://bugs.webkit.org/show_bug.cgi?id=118568

Attachment 206474: Patch
https://bugs.webkit.org/attachment.cgi?id=206474&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206474&action=review


Looks good except for the include line.

> Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:39
> +#include <GOwnPtr.h>

I think you want <wtf/gobject/GOwnPr.h> here.


More information about the webkit-reviews mailing list