[webkit-reviews] review granted: [Bug 118504] Introduce isSVGFontElement() and isSVGImageElement(), use them : [Attachment 206317] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 9 20:26:58 PDT 2013


Benjamin Poulain <benjamin at webkit.org> has granted Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 118504: Introduce isSVGFontElement() and isSVGImageElement(), use them
https://bugs.webkit.org/show_bug.cgi?id=118504

Attachment 206317: Patch
https://bugs.webkit.org/attachment.cgi?id=206317&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206317&action=review


> Source/WebCore/svg/SVGFontElement.h:95
> +    ASSERT_WITH_SECURITY_IMPLICATION(!node || isSVGFontElement(node));

How did that compile with isSVGFontElement() declared underneath?

> Source/WebCore/svg/SVGImageElement.h:94
> +inline bool isSVGImageElement(const Element* node)
> +{
> +    return node->hasTagName(SVGNames::imageTag);
> +}

Why? Element is a node. This should not be needed.


More information about the webkit-reviews mailing list