[webkit-reviews] review requested: [Bug 118482] fourthTier: Change JSStack to use macro to determine stack growth direction : [Attachment 206359] Updated patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 9 17:21:12 PDT 2013
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 118482: fourthTier: Change JSStack to use macro to determine stack growth
direction
https://bugs.webkit.org/show_bug.cgi?id=118482
Attachment 206359: Updated patch
https://bugs.webkit.org/attachment.cgi?id=206359&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
Limited the #ifdef's to JSStack files. The ifdef's are needed due to doing
arithmetic or comparisons with pointers or size_t type values. In both cases,
we can't use the multiply by -1 or 1 trick. In some cases, we could create an
#ifdef'ed help function to do <= comparisons or pointer arithmetic, but I felt
that would obfuscate the reading of the code.
If this patch isn't acceptable, then I think it is mega patch time.
More information about the webkit-reviews
mailing list