[webkit-reviews] review requested: [Bug 117895] [v2.1.2] GTK2 build fails for undefined GDK_IS_X11_DISPLAY : [Attachment 206349] New version, hopefully translated all comments into the right snippets. Patch build-tested with webkitgtk 2.1.3 / gtk2 2.24.19

[bugzilla-daemon at webkit.org]

Dominique Leuenberger <dimstar at opensuse.org> has asked	for review:
Bug 117895: [v2.1.2] GTK2 build fails for undefined GDK_IS_X11_DISPLAY
https://bugs.webkit.org/show_bug.cgi?id=117895

Attachment 206349: New version, hopefully translated all comments into the
right snippets. Patch build-tested with  webkitgtk 2.1.3 / gtk2 2.24.19
https://bugs.webkit.org/attachment.cgi?id=206349&action=review

------- Additional Comments from Dominique Leuenberger <dimstar at opensuse.org>
Build failures addressed in new patch:

1)
Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:749:58: error:
'gtk_widget_get_preferred_size' was not declared in this scope
     gtk_widget_get_preferred_size(widget, &requisition, 0);


2)
Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp: In function
'WTF::PassOwnPtr<WebCore::WidgetBackingStore>
WebKit::createBackingStore(GtkWidget*, const WebCore::IntSize&)':
Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp:111:35: error:
'GDK_IS_X11_DISPLAY' was not declared in this scope
     if (GDK_IS_X11_DISPLAY(display))

3)
In file included from Source/WebCore/plugins/gtk/gtk2xtbin.c:47:0:
Source/WebCore/plugins/gtk/gtk2xtbin.h:45:22: fatal error: gtk/gtkx.h: No such
file or directory
 #include <gtk/gtkx.h>
		      ^