[webkit-reviews] review denied: [Bug 118505] Leak: TextCodecICU::registerCodecs is leaking : [Attachment 206319] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 118505: Leak: TextCodecICU::registerCodecs is leaking
https://bugs.webkit.org/show_bug.cgi?id=118505

Attachment 206319: Patch
https://bugs.webkit.org/attachment.cgi?id=206319&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that the leak may be real, but the fix is not right.

Generally, these strings are permanently stored in textCodecMap, and not
leaked. One case where a leak may occur is when the same webStandardName is
registered multiple times - when this happens, map value is thrown away.

However, I don't think that it's correct to remove fastStrDup. The result of
ucnv_getCanonicalName is not documented to remain useful indefinitely - for
example, they may be reusing a static buffer. So, we need our own copy of the
string.