[webkit-reviews] review denied: [Bug 118409] Non-power-of-two texture handle optimization : [Attachment 206133] Non power of two texture handle optimization

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Przemyslaw Szymanski
<p.szymanski3 at samsung.com>'s request for review:
Bug 118409: Non-power-of-two texture handle optimization
https://bugs.webkit.org/show_bug.cgi?id=118409

Attachment 206133: Non power of two texture handle optimization
https://bugs.webkit.org/attachment.cgi?id=206133&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206133&action=review


Needs a lot of cleanup, mainly names etc.

> Source/WebCore/ChangeLog:8
> +	   This patch optimizes usage of handleNPOTTextures. It is not need to

is -> does

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:547
> +    if (isNPOTTSupport())

hasNPOTSupport

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:1987
> +    bool invalidTex = false;

Tex -> Texture

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2072
> +    bool invalidTex = false;

Ditto

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4803
> +bool WebGLRenderingContext::handleInvalidTextures(const char* functionName,
bool prepareToDraw)

What are invalid textures? Maybe this should be prepareNonRenderableTextures?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4806
> +    bool blackTexSet = false;

something like hasBlackTexture?