[webkit-reviews] review granted: [Bug 118457] DeleteSelectionCommand does not handle correctly deletion with two consecutive BR element. : [Attachment 206224] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 118457: DeleteSelectionCommand does not handle correctly deletion with two
consecutive BR element.
https://bugs.webkit.org/show_bug.cgi?id=118457

Attachment 206224: Patch
https://bugs.webkit.org/attachment.cgi?id=206224&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206224&action=review


> Source/WebCore/editing/DeleteSelectionCommand.cpp:312
> +    // when the two elements are sibling and should be false in a case like
<div><br></div><br>.

…are siblings...

> LayoutTests/editing/deleting/delete-image-followed-by-two-br-expected.txt:1
> +CONSOLE MESSAGE: line 16: TypeError: 'undefined' is not a function
(evaluating 'document.getElementsById("test")')

Should this be here?