[webkit-reviews] review denied: [Bug 118060] Old Bug Validator Tool : [Attachment 206245] OldBugValidatorTool Python

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has denied Gábor Ábrahám
<abrhm at inf.u-szeged.hu>'s request for review:
Bug 118060: Old Bug Validator Tool
https://bugs.webkit.org/show_bug.cgi?id=118060

Attachment 206245: OldBugValidatorTool Python
https://bugs.webkit.org/attachment.cgi?id=206245&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206245&action=review


Thanks for posting the patch. However, this shouldn't be a standalone python
script.
There is a code to parse TestExpectations under
Tools/Scripts/webkitpy/layout_tests.
We should be using that parser instead. There is also a code to fetch Bugzilla
data. See code in Tools/Scripts/webkitpy/tool.

> Tools/ChangeLog:3
> +	   Implementing Old Bug Validator Tool in Python. The aim is to check
TestExpectations file for RESOLVED bugs in an easier way.

This line should be of the bug summary & url. See other entries.
This long description should appear below Reviewed by line. Agan, see other
entries.

Please read http://www.webkit.org/coding/contributing.html.

> Tools/Scripts/old-bug-validator.py:4
> +# Copyright (C) 2013 University of Szeged
> +# Copyright (C) 2013 Gabor Abraham <abrhm at inf.u-szeged.hu>
> +# All rights reserved.

Wrong copyright format. See other files.