[webkit-reviews] review granted: [Bug 103336] [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns} : [Attachment 205201] Rename instead of alias and fix tests

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 103336: [CSS Grid Layout] Rename grid-{rows|columns} to
grid-definition-{rows|columns}
https://bugs.webkit.org/show_bug.cgi?id=103336

Attachment 205201: Rename instead of alias and fix tests
https://bugs.webkit.org/attachment.cgi?id=205201&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205201&action=review


> Source/WebCore/ChangeLog:10
> +	   Alias -webkit-grid-{rows|columns} to
-webkit-grid-definition-{rows|columns}.
> +	   The latest version of the spec has renamed these properties and an
alias
> +	   preserves backwards compatibility with older CSS.

This still talks about aliasing.

> Source/WebCore/ChangeLog:13
> +	   (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Handle
the new aliases.

Here too.

> Source/WebCore/ChangeLog:20
> +	   * css/CSSPropertyNames.in: Add support for the new aliases.
> +	   * css/StyleResolver.cpp:
> +	   (WebCore::StyleResolver::applyProperty): Handle the new aliases.

Also here.