[webkit-reviews] review granted: [Bug 61956] Remember the scroll position and restore after exiting full-screen mode. : [Attachment 188356] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 61956: Remember the scroll position and restore after exiting full-screen
mode.
https://bugs.webkit.org/show_bug.cgi?id=61956

Attachment 188356: Patch
https://bugs.webkit.org/attachment.cgi?id=188356&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=188356&action=review


> Source/WebKit2/ChangeLog:44
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Remember the scroll position and restore after exiting full-screen
mode.
> +	   https://bugs.webkit.org/show_bug.cgi?id=61956
> +
> +	   Add support for two new FullScreenClient callbacks for saving and
restoring the 
> +	   full-screen frame's scroll position.
> +
> +	   * UIProcess/win/WebView.cpp:
> +	   (WebKit::WebView::fullScreenClientSaveScrollPosition):
> +	   (WebKit::WebView::fullScreenClientRestoreScrollPosition):
> +	   * UIProcess/win/WebView.h:
> +
> +2011-06-29  Jeremy Noble  <jer.noble at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Remember the scroll position and restore after exiting full-screen
mode.
> +	   https://bugs.webkit.org/show_bug.cgi?id=61956
> +	   <rdar://problem/9544461>
> +
> +	   Call into the main FrameView to save the scroll position before
swapping the
> +	   WebView into the full-screen window, and restore the scroll position
after 
> +	   swapping the WebView back into the browser window.
> +
> +	   * UIProcess/mac/WKFullScreenWindowController.mm:
> +	   (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):

> +	   (-[WKFullScreenWindowController beganExitFullScreenAnimation]):
> +
> +	   In WebKit2, this requires some communication between the WebProcess
and the
> +	   UIProcess, so add two new messages to WebFullScreenManager to be
called by
> +	   its proxy.
> +
> +	   * UIProcess/WebFullScreenManagerProxy.h:
> +	   * UIProcess/WebFullScreenManagerProxy.cpp:
> +	   (WebKit::WebFullScreenManagerProxy::saveScrollPosition):
> +	   (WebKit::WebFullScreenManagerProxy::restoreScrollPosition):
> +	   * WebProcess/FullScreen/WebFullScreenManager.h:
> +	   * WebProcess/FullScreen/WebFullScreenManager.messages.in:
> +	   * WebProcess/FullScreen/WebFullScreenManager.cpp:
> +	   (WebKit::WebFullScreenManager::saveScrollPosition):
> +	   (WebKit::WebFullScreenManager::restoreScrollPosition):

Two changelogs!