[webkit-reviews] review granted: [Bug 118369] REGRESSION(r125294): A style rule with more than 8192 selectors can cause style corruption. : [Attachment 206235] Proposed patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 118369: REGRESSION(r125294): A style rule with more than 8192 selectors can
cause style corruption.
https://bugs.webkit.org/show_bug.cgi?id=118369

Attachment 206235: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=206235&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=206235&action=review


> Source/WebCore/css/StyleRule.cpp:275
> +Vector<RefPtr<StyleRule> >
StyleRule::splitIntoMultipleRulesWithMaximumSelectorCount(unsigned
maxSelectorCount) const

max -> maximum

> Source/WebCore/css/StyleRule.cpp:284
> +    for (const CSSSelector* s = selectorList().first(); s; s =
CSSSelectorList::next(s)) {

s?!

> Source/WebCore/css/StyleRule.cpp:285
> +	   for (const CSSSelector* subSelector = s; subSelector; subSelector =
subSelector->tagHistory())

component or selectorComponent would be a better name. We use "subSelector"
specifically to mean components that match a single element (relation ==
SubSelector).