[webkit-reviews] review requested: [Bug 118405] Update Exception handling in WebAudio : [Attachment 206215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 7 21:39:10 PDT 2013


Praveen Jadhav <praveen.j at samsung.com> has asked  for review:
Bug 118405: Update Exception handling in WebAudio
https://bugs.webkit.org/show_bug.cgi?id=118405

Attachment 206215: Patch
https://bugs.webkit.org/attachment.cgi?id=206215&action=review

------- Additional Comments from Praveen Jadhav <praveen.j at samsung.com>
Patch updated as per the review comments. Description for start and stop
methods in AudioBufferSourceNode says 'an exception will be thrown' but doesn't
specify the exact DOM exception. INVALID_STATE_ERR seems to be appropriate
error in this case.

@crogers: WDYT?


More information about the webkit-reviews mailing list