[webkit-reviews] review granted: [Bug 118440] Tons of crashes on bots after r152425 : [Attachment 206185] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jul 5 21:51:32 PDT 2013
Sam Weinig <sam at webkit.org> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 118440: Tons of crashes on bots after r152425
https://bugs.webkit.org/show_bug.cgi?id=118440
Attachment 206185: patch
https://bugs.webkit.org/attachment.cgi?id=206185&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206185&action=review
> Source/WebCore/page/FrameView.cpp:1646
> + if (Page* page = m_frame->page()) {
I would do an early return.
> Source/WebCore/page/FrameView.cpp:1658
> + Page* page = m_frame->page();
I would early return here.
More information about the webkit-reviews
mailing list