[webkit-reviews] review granted: [Bug 118368] Nix upstreaming - Adding Nix render theme files : [Attachment 206025] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Tullio Lucena
<tullio.lucena at openbossa.org>'s request for review:
Bug 118368: Nix upstreaming - Adding Nix render theme files
https://bugs.webkit.org/show_bug.cgi?id=118368

Attachment 206025: Patch
https://bugs.webkit.org/attachment.cgi?id=206025&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206025&action=review


Use real name: o-> renderObject. i->info|paintInfo.

> Source/WebCore/platform/nix/RenderThemeNix.cpp:276
> +void RenderThemeNix::adjustProgressBarStyle(StyleResolver*, RenderStyle*
style, Element *) const

Element * -> Element*

> Source/WebCore/platform/nix/RenderThemeNix.h:33
> +class RenderThemeNix : public RenderTheme {

Plenty of missing OVERRIDE.

> Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:29
> +#include "NotImplemented.h"

Why?

> Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:30
> +#include <stdio.h>

Why?

> Source/WebCore/platform/nix/ScrollbarThemeNix.cpp:46
> +    return 0; // we paint on top

Fix the comment.

> Source/WebCore/platform/nix/ScrollbarThemeNix.h:33
> +class ScrollbarThemeNix : public ScrollbarTheme {

Missing OVERRIDEs.