[webkit-reviews] review requested: [Bug 118410] Segmentation fault occurred when ICU data library doesn't embed the expected encoding : [Attachment 206139] Segmentation fault occurred when ICU data library doesn't embed the expected encoding.

[bugzilla-daemon at webkit.org]

Benjamin Dupont <bdupont at nds.com> has asked  for review:
Bug 118410: Segmentation fault occurred when ICU data library doesn't embed the
expected encoding
https://bugs.webkit.org/show_bug.cgi?id=118410

Attachment 206139: Segmentation fault occurred when ICU data library doesn't
embed the expected encoding.
https://bugs.webkit.org/attachment.cgi?id=206139&action=review

------- Additional Comments from Benjamin Dupont <bdupont at nds.com>
The problem is into the newTextCodec function from
Source/WebCore/platform/text/TextEncodingRegistry.cpp. The textCodecMap hash
map doesn't contain a factory for the Shift_JIS encoding thus factory.function
is null. 
In this case, the first factory in the hash map is used. It's not a perfect
solution, it's just to avoid the segmentation fault.