[webkit-reviews] review granted: [Bug 118393] Adopt is/toHTMLTableElement for code cleanup : [Attachment 206087] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 118393: Adopt is/toHTMLTableElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118393

Attachment 206087: Patch
https://bugs.webkit.org/attachment.cgi?id=206087&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206087&action=review


r=me with some minor changes:

> Source/WebCore/html/HTMLTableElement.h:103
> +inline bool isHTMLTableElement(Node* node)

The argument should be const Node*, otherwise we can only call
isHTMLTableElement on non-const Nodes.

> Source/WebCore/html/HTMLTableElement.h:111
> +inline bool isHTMLTableElement(Element* element)
> +{
> +    return element->hasTagName(HTMLNames::tableTag);
> +}

This overload shouldn't be necessary.