[webkit-reviews] review granted: [Bug 111434] [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib : [Attachment 206119] Fixing according to Martin's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 4 19:34:12 PDT 2013


Martin Robinson <mrobinson at webkit.org> has granted Xabier Rodríguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 111434: [GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent
glib
https://bugs.webkit.org/show_bug.cgi?id=111434

Attachment 206119: Fixing according to Martin's comments
https://bugs.webkit.org/attachment.cgi?id=206119&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=206119&action=review


> Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:234
> +    // These tests depend on this order to run properly so we declare
> +    // them in a single one. See
> +    // https://bugs.webkit.org/show_bug.cgi?id=111434.

Just a note for the future: comments in WebKit can be long lines (up to and
past 120 characters), so feel free not to break them into more lines.


More information about the webkit-reviews mailing list