[webkit-reviews] review denied: [Bug 118381] gtk_icon_info_free is deprecated since GTK+ 3.8 : [Attachment 206062] Proposed

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has denied Iago Toral
<itoral at igalia.com>'s request for review:
Bug 118381: gtk_icon_info_free is deprecated since GTK+ 3.8
https://bugs.webkit.org/show_bug.cgi?id=118381

Attachment 206062: Proposed 
https://bugs.webkit.org/attachment.cgi?id=206062&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
We can't do this, we depend on GTK+ 3.6, where GtkIconInfo is not a GObject but
a boxed type. We need to add an #ifdef until we bump the required version to
3.8, or we can simply ignore deprecated symbols in gtk versions grater than
3.6. I even proposed a patch to remove the annoying warnings for those cases
indeed, see bug #118237.