[webkit-reviews] review denied: [Bug 118326] Preparing WebCore to receive Nix Port : [Attachment 205945] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 118326: Preparing WebCore to receive Nix Port
https://bugs.webkit.org/show_bug.cgi?id=118326

Attachment 205945: Patch
https://bugs.webkit.org/attachment.cgi?id=205945&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205945&action=review


> Source/WebCore/platform/DragImage.h:64
> -#elif PLATFORM(GTK)
> +#elif PLATFORM(GTK) || PLATFORM(NIX)
>      typedef cairo_surface_t* DragImageRef;

I wonder why this isn't under USE(CAIRO).

> Source/WebCore/platform/FileSystem.h:124
> -#elif PLATFORM(GTK)
> +#elif PLATFORM(GTK) || PLATFORM(NIX)
>  typedef GFileIOStream* PlatformFileHandle;

I wonder if we should add USE(GLIB). It's quite confusing that "G" types are
used by two platforms, one of which doesn't have a "G" in its name.

> Source/WebCore/platform/PlatformMenuDescription.h:38
> +#elif PLATFORM(NIX)
> +#include <wtf/Vector.h>

Why is this needed?  You are not changing this file in any other way, and this
file is not using Vector.

> Source/WebCore/platform/audio/FFTFrame.h:189
> +#if PLATFORM(NIX)
> +    void scalePlanarData(float scale);
> +    OwnPtr<WebKit::WebFFTFrame> m_fftFrame;
> +#endif // PLATFORM(NIX)

Ugh, WebCore is not supposed to know anything about WebKit. This is a terrible
layering violation.