[webkit-reviews] review canceled: [Bug 118307] [ATK] Leak: AtkAttributeSet* should be freed : [Attachment 206009] Revised patch

[bugzilla-daemon at webkit.org]

Brian Holt <brian.holt at samsung.com> has canceled Brian Holt
<brian.holt at samsung.com>'s request for review:
Bug 118307: [ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307

Attachment 206009: Revised patch
https://bugs.webkit.org/attachment.cgi?id=206009&action=review

------- Additional Comments from Brian Holt <brian.holt at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206009&action=review


>>>> Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:56

>>>> +static char* getAtkAttributeSetAsString(AtkObject* accessible)
>>> 
>>> gchar
>> 
>> Regarding the gchars, I was under the impression that for new code that is
not exposed to the outside world we should be using the non-g-versions.  If
that's not correct then I will happily change to gchars throughout.
> 
> Hmm, I'm not aware of that. Last I heard, gchar was preferred but the
situation might have changed since then. Do you have a link to a review /
comment supporting what you're saying?

Just hearsay at the moment, I'll see if I can fish out a link tomorrow.