[webkit-reviews] review granted: [Bug 118359] [ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR : [Attachment 206007] Patch proposal plus new Unit test

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has granted Mario Sanchez Prada
<mario at webkit.org>'s request for review:
Bug 118359: [ATK] Do not expose '\n' for wrapped lines with
ATK_TEXT_BOUNDARY_CHAR
https://bugs.webkit.org/show_bug.cgi?id=118359

Attachment 206007: Patch proposal plus new Unit test
https://bugs.webkit.org/attachment.cgi?id=206007&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=206007&action=review


> Source/WebKit/gtk/tests/testatk.c:952
> +    webkit_web_view_load_string(webView, contentsWithWrappedLines, 0, 0, 0);


Don't you need to run a main loop and wait until the page is loaded to continue
with the test?

> Source/WebKit/gtk/tests/testatk.c:956
> +    g_object_set(G_OBJECT(settings), "enable-caret-browsing", TRUE, NULL);

g_object_set receives a gpointer, not a GObject, so you don't need the cast.

> Source/WebKit/gtk/tests/testatk.c:995
> +    /* Check the paragraph with the text wrapped because of <br> elements.
*/

You are mixing C and C++ comments in this test, please fix it before landing.